2007-01-15 22:33 Ed Larty * WebDocs/: FrozenRel.html, WebDocs.html, packages-info.txt: # modified advertised release packages 2007-01-15 22:30 Ed Larty * setup/packages-R1.24.1: # new frozen tag R1.24.1 2007-01-15 21:05 Robert Hatcher * PulserCalibration/CheckGC/FitGC.cxx, RootUtil/TPSTest/TPSTest.cxx, UgliGeometry/MinosOutline.cxx, VALinCalibration/VALinFit.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:57 Robert Hatcher * Persistency/PerOutputStream.cxx: A change in ROOT headers means we need an explicit #include "TClass.h". 2007-01-15 20:55 Robert Hatcher * ParticleTransportSim/: PTSimHit.h, PTSimStack.h: Changes in ROOT headers means that we need to explicitly add some #includes. 2007-01-15 20:53 Robert Hatcher * MCApplication/MCAppUser.h: Changes in ROOT headers means we need explicit #include to pick up DBL_MAX. 2007-01-15 20:42 Robert Hatcher * NuBarPID/PIDCalculator.cxx, NueAna/MSTTemplate.cxx, OfflineHistograms/FitTrackFDHistogramBlock.cxx, OfflineHistograms/TrackHistogramBlock.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:35 Robert Hatcher * NtupleUtils/NuZBeamReweight.cxx: A change in ROOT headers means we need an explicit #include "TDirectory.h" in order to access gDirectory. 2007-01-15 20:33 Robert Hatcher * MuonRemoval/SelectEvent.cxx, NCUtils/NCExtraction.cxx, NCUtils/NCExtractionADM.cxx, NCUtils/NCExtractionDP.cxx, NCUtils/NCExtractionTO.cxx, NeugenInterface/xsec_vs_energy.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:27 Robert Hatcher * Monitoring/ChargeInjectAnalysis.cxx, Monitoring/LIAdcAnalysis.cxx, Monitoring/QieBlockAnalysis.cxx, Monitoring/SinglAnalysis.cxx, MuCal/MuCalTrunc.cxx, MuCal/SpectraFit.C: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:20 Robert Hatcher * MCReweight/BMPTHistoWeightCalculator.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:18 Robert Hatcher * MCMonitor/MCMonitor.cxx: A change in ROOT headers means we need an explicit #include "TROOT.h" in order to have access to gRoot. 2007-01-15 20:16 Robert Hatcher * MCMerge/ConcatArrays.cxx: Change in ROOT headers means that we need an explicit #include "TClass.h". 2007-01-15 20:12 Robert Hatcher * DetSim/SimPmtM16.cxx, DetSim/SimPmtM64.cxx, DetSim/SimPmtM64Oxford.cxx, LISummary/LILookup.cxx, LISummary/LIPmt.cxx, LISummary/LISummarySorter.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:05 Robert Hatcher * DetSim/: SimDaqPlaneTrigger.h, SimDaqTrigMaker.h, SimElecMaker.h, SimPmtMaker.h, SimQieClock.h: Explicit ctor's and virtual dtor's make gcc 4.x happier if there's a ClassDef. 2007-01-15 20:02 Robert Hatcher * CandTrackCam/CandTrackCamHandle.cxx, CandTrackSR/CandTrackSRHandle.cxx, CandTrackSR/HoughTrackSR.cxx, CandTrackSR/HoughViewSR.cxx, DataQualityMonitoring/EfficiencyPurityModule.cxx, DataQualityMonitoring/EventRatePlotModule.cxx, DataQualityMonitoring/RecoMonitoring.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 20:01 Robert Hatcher * DataQualityMonitoring/BeamMonitoring.h: A change in ROOT headers means we need an explicit "class TFile;" 2007-01-15 19:52 Robert Hatcher * AtNuOutput/AlgFarDetSlice.cxx, AtNuReco/TrackSegmentAtNu.cxx, AtNuUtils/CamEvd.cxx, AtNuUtils/FarLayout.cxx, AtNuUtils/UtilCanvas.cxx, AtNuUtils/UtilHist.cxx, AtNuUtils/VetoShower.cxx, AtNuUtils/VetoTrack.cxx, BField/BfldDbiPlaneMap.cxx, BeamData/ana/Bdtxt.cxx, BeamData/ana/bv/ProtonDist.cxx, BeamDataUtil/BeamMonSpill.cxx, BubbleSpeak/AlgStraightCluster.cxx, CalDetDBUtils/BeamLossCalib.cxx, CalDetDBUtils/LoadBeamErrors.cxx, CalDetDST/CalDet2003PlotsModule.cxx, CalDetSI/Helpers.h, CalDetTracker/CDTracker.cxx, Calibrator/CalLinearity.cxx, Calibrator/CalMapperFits.cxx, Calibrator/CalStripAtten.cxx, Calibrator/CalVaLinearity.cxx: Add a liberal smattering of #include "TMath.h" or #include to account for changes in ROOT that mean that those are no longer implicitly included. 2007-01-15 17:22 kordosky * Contrib/rhatcher/gminos_jobs/submit_ral.sh: previous commit was not desired. 2007-01-15 17:20 kordosky * Contrib/rhatcher/gminos_jobs/: gminos_cfg_L010185_near_charm.py, submit_ral.sh: in charm configuration, we need [] around "ACPT 1" card. 2007-01-15 15:40 raufer * NCUtils/: NCAnalysisModule.cxx, NCAnalysisUtils.cxx, NCExtractionResultsADM.cxx: Mostly memory management: delete objects in the destructor One bug fix in NCExtractionResultsADM.cxx: array initialisation error in line 37 2007-01-15 15:37 blake * AtNuAna/: AtNuEventSelectionAB.cxx, AtNuEventSelector.cxx, AtNuEventSelector.h: make event type determination independent of event filter 2007-01-15 14:31 Nick West * DatabaseMaintenance/tools/load_tables.sh: Add --no_refresh_ins Don't refresh INSERTDATE, just leave as set in tar file (handy to make a 'image' copy of a table, but recommend deleting checksum log of table before running any checksum as INSERTDATE used to force regeneration of checksum entries) 2007-01-15 13:07 Nick West * Calibrator/CalPmtDrift.h: Add include "TMath.h" as recent restructuring of part of TMath.h into TMathBase.h means that TString.h uses TMathBase.h instead of TMath.h. As the ROOT commit explains:- As a result, it was necessary to include "TMath.h" in some classes assuming that TMath was included via TString and using other functions than the ones defined in TMathBase.h 2007-01-15 11:01 Nick West * MCNtuple/NtpMCStdHep.h: Add include "TMath.h" as recent restructuring of part of TMath.h into TMathBase.h means that TString.h uses TMathBase.h instead of TMath.h. As the ROOT commit explains:- As a result, it was necessary to include "TMath.h" in some classes assuming that TMath was included via TString and using other functions than the ones defined in TMathBase.h 2007-01-15 10:37 raufer * NCUtils/: NCAnalysisModule.cxx, NCExtraction.cxx, NCExtractionTO.cxx, NCExtractionTR.cxx, NCExtractionTRann.cxx, macros/ncccSeparationTR.C: Fixed one small and one large problem. The small one first: The new constructors for the NCExtractionXX classes create a new problem. The NCExtractionXX objects get passed pointers to the cuts and utils objects. They therefore don't "own" these objects anymore and consequently should not delete them in their destructors. So I commented out the relevant lines from the destructors. So far so good. Unfortunately, this creates a problem if for whatever reason, the old constructors are used. They create cuts and utils objects on the heap. This is now a (small) memory leak. I think, it's better to live with this small memory leak for now than having pointers potentially pointing off to nowhere. Now the big problem: We have a "truth" branch in our data output trees. This is for the case when one uses MC as fake data. The branch addresses were only set if really running on MC as fake data. But the tree had this branch even in other cases. Now when executing the TTree->Fill(), root noticed that the "truth" branch was not set to anything sensible. It therefore created a "ANtpTruthInfo" object on the heap and did NOT delete it afterwards. This was done for each event. In my 10+10 files test job, this created a memory leak of 24M. I fixed it by adding to more if statements "if (fUseMCAsData) fNtuple->Branch(...)" etc. So now, the ntuple does not even have a truth branch if fUseMCAsData is set to false. This should work, I think. Tobi 2007-01-15 02:37 Sue Kasahara * MCNtuple/: LinkDef.h, NtpMCGenInfo.cxx, NtpMCGenInfo.h, NtpMCSummary.cxx, NtpMCSummary.h, Module/NtpMCModule.cxx: Store MC generator information as extracted from SimSnarlHeader, resulting in new NtpSt leaves: mchdr.geninfo.time // time of MC generation mchdr.geninfo.codename // generator MC code tag mchdr.geninfo.hostname // machine that generated event 2007-01-15 02:17 Sue Kasahara * Record/SimSnarlHeader.h: Initialize fMcGenTime in default constructor to fMcGenTime(0,0), so that when reading existing mc files the generator time will be set to an invalid time. 2007-01-15 01:41 Sue Kasahara * Record/SimSnarlHeader.h: Add accessor methods to mc generator info data members. 2007-01-14 18:45 kordosky * Contrib/rhatcher/gminos_jobs/copy_flux_files_ral.sh: handle charm configuration 2007-01-14 12:54 kordosky * Contrib/rhatcher/gminos_jobs/submit_ral.sh: small update 2007-01-12 21:46 Ed Larty * WebDocs/: FrozenRel.html, packages-info.txt: # announced new generic release 2007-01-12 21:30 Brian Rebel * AnalysisNtuples/macros/makeCondensedNtupleNC.C: committing standard version of this script 2007-01-12 19:04 kordosky * Contrib/kordosky/neugen_4vec/: Makefile, access_inuke_xsecs.cc, compare_neugen.sh, inuke_reweight.F, plot_mashnik.C: some code to look at intranuke cross sections 2007-01-12 18:08 Robert Hatcher * MINF_Classes/MINFAttParticle.cxx: Add some D0-bar (and D0*-bar) entries to avoid THashList::GetParticle error messages now that NEUGEN3 generates such things. This should suppress such messages in Daikon processing. 2007-01-12 18:05 Robert Hatcher * MINF_Classes/MINFAttParticle.cxx: Add some D0-bar (and D0*-bar) entries to avoid THashList::GetParticle error messages now that NEUGEN3 generates such things. 2007-01-12 17:32 thosieck * NCUtils/macros/ncccSeparationTO.C: Commiting Tom O's job script with some updates, namely adding a neugen weight calculator